You’re absolutely right to ask this. I took a look at wikiquote (which wouldn’t still prove anything by itself) and that quote isn’t there: https://en.wikiquote.org/wiki/Smedley_Butler

However, it fits his anti-war and anti-capitalist sentiments and his often angry tone quite well, so it might be legit.